Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds check for tagging UDP and WS trackers #448

Conversation

Antorell
Copy link

Description

Fixes #183 by allowing UDP and WS trackers to have their own tags rather than being forced to the "Other" catch-all tag.

Fixes # #183

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have added or updated the docstring for new or existing methods
  • I have modified this PR to merge to the develop branch
|====================================================================================================|
|                           _     _ _                                                                |
|                          | |   (_) |                                                               |
|                      __ _| |__  _| |_   _ __ ___   __ _ _ __   __ _  __ _  ___                     |
|                     / _` | '_ \| | __| | '_ ` _ \ / _` | '_ \ / _` |/ _` |/ _ \                    |
|                    | (_| | |_) | | |_  | | | | | | (_| | | | | (_| | (_| |  __/                    |
|                     \__, |_.__/|_|\__| |_| |_| |_|\__,_|_| |_|\__,_|\__, |\___|                    |
|                        | |         ______                            __/ |                         |
|                        |_|        |______|                          |___/                          |
|     Version: 4.0.6 (Python 3.11.5)                                                                 |
|     Platform: Windows-10-10.0.19045-SP0                                                            |
|     Run Mode: Script will exit after completion.                                                   |
|====================================================================================================|
|                                            Starting Run                                            |
|====================================================================================================|
| Locating config...                                                                                 |
| Using Z:\qbit_manage\config\config.yml as config                                                   |
| Commands found in config.yml, ignoring env variables and using config commands instead.            |
| Connecting to Qbittorrent...                                                                       |
| Qbt Connection Successful                                                                          |
|======================================= Getting Torrent List =======================================|
|======================================== Checking Settings =========================================|
|====================================================================================================|
|                                   Gathering Torrent Information                                    |
|====================================================================================================|
|========================================== Updating Tags ===========================================|
|    Torrent Name: neon-user-20231109-0718.iso                                                       |
|         New Tag: openbittorrent                                                                    |
|         Tracker: udp://tracker.openbittorrent.com:80                                               |
| Updated 1 new tags.                                                                                |
|============================= Updating Share Limits based on priority ==============================|
| Assigning torrents to share limit groups...                                                        |
|====================================================================================================|
|                                            Finished Run                                            |
|                                      Total Torrents Tagged: 1                                      |
|                                         Run Time: 0:00:00                                          |
|====================================================================================================|

|====================================================================================================|
|                           _     _ _                                                                |
|                          | |   (_) |                                                               |
|                      __ _| |__  _| |_   _ __ ___   __ _ _ __   __ _  __ _  ___                     |
|                     / _` | '_ \| | __| | '_ ` _ \ / _` | '_ \ / _` |/ _` |/ _ \                    |
|                    | (_| | |_) | | |_  | | | | | | (_| | | | | (_| | (_| |  __/                    |
|                     \__, |_.__/|_|\__| |_| |_| |_|\__,_|_| |_|\__,_|\__, |\___|                    |
|                        | |         ______                            __/ |                         |
|                        |_|        |______|                          |___/                          |
|     Version: 4.0.6 (Python 3.11.5)                                                                 |
|     Platform: Windows-10-10.0.19045-SP0                                                            |
|     Run Mode: Script will exit after completion.                                                   |
|====================================================================================================|
|                                            Starting Run                                            |
|====================================================================================================|
| Locating config...                                                                                 |
| Using Z:\qbit_manage\config\config.yml as config                                                   |
| Commands found in config.yml, ignoring env variables and using config commands instead.            |
| Connecting to Qbittorrent...                                                                       |
| Qbt Connection Successful                                                                          |
|======================================= Getting Torrent List =======================================|
|======================================== Checking Settings =========================================|
|====================================================================================================|
|                                   Gathering Torrent Information                                    |
|====================================================================================================|
|========================================== Updating Tags ===========================================|
|    Torrent Name: neon-user-20231109-0718.iso                                                       |
|         New Tag: openbittorrent                                                                    |
|         Tracker: ws://tracker.openbittorrent.com:80                                                |
| Updated 1 new tags.                                                                                |
|============================= Updating Share Limits based on priority ==============================|
| Assigning torrents to share limit groups...                                                        |
|====================================================================================================|
|                                            Finished Run                                            |
|                                      Total Torrents Tagged: 1                                      |
|                                         Run Time: 0:00:00                                          |
|====================================================================================================|

|====================================================================================================|
|                           _     _ _                                                                |
|                          | |   (_) |                                                               |
|                      __ _| |__  _| |_   _ __ ___   __ _ _ __   __ _  __ _  ___                     |
|                     / _` | '_ \| | __| | '_ ` _ \ / _` | '_ \ / _` |/ _` |/ _ \                    |
|                    | (_| | |_) | | |_  | | | | | | (_| | | | | (_| | (_| |  __/                    |
|                     \__, |_.__/|_|\__| |_| |_| |_|\__,_|_| |_|\__,_|\__, |\___|                    |
|                        | |         ______                            __/ |                         |
|                        |_|        |______|                          |___/                          |
|     Version: 4.0.6 (Python 3.11.5)                                                                 |
|     Platform: Windows-10-10.0.19045-SP0                                                            |
|     Run Mode: Script will exit after completion.                                                   |
|====================================================================================================|
|                                            Starting Run                                            |
|====================================================================================================|
| Locating config...                                                                                 |
| Using Z:\qbit_manage\config\config.yml as config                                                   |
| Commands found in config.yml, ignoring env variables and using config commands instead.            |
| Connecting to Qbittorrent...                                                                       |
| Qbt Connection Successful                                                                          |
|======================================= Getting Torrent List =======================================|
|======================================== Checking Settings =========================================|
|====================================================================================================|
|                                   Gathering Torrent Information                                    |
|====================================================================================================|
|========================================== Updating Tags ===========================================|
|    Torrent Name: neon-user-20231109-0718.iso                                                       |
|         New Tag: openbittorrent                                                                    |
|         Tracker: udp://tracker.openbittorrent.com:80                                               |
| Updated 1 new tags.                                                                                |
|============================= Updating Share Limits based on priority ==============================|
| Assigning torrents to share limit groups...                                                        |
|====================================================================================================|
|                                            Finished Run                                            |
|                                      Total Torrents Tagged: 1                                      |
|                                         Run Time: 0:00:00                                          |
|====================================================================================================|

(.venv) Z:\qbit_manage>python qbit_manage.py --run
|====================================================================================================|
|                           _     _ _                                                                |
|                          | |   (_) |                                                               |
|                      __ _| |__  _| |_   _ __ ___   __ _ _ __   __ _  __ _  ___                     |
|                     / _` | '_ \| | __| | '_ ` _ \ / _` | '_ \ / _` |/ _` |/ _ \                    |
|                    | (_| | |_) | | |_  | | | | | | (_| | | | | (_| | (_| |  __/                    |
|                     \__, |_.__/|_|\__| |_| |_| |_|\__,_|_| |_|\__,_|\__, |\___|                    |
|                        | |         ______                            __/ |                         |
|                        |_|        |______|                          |___/                          |
|     Version: 4.0.6 (Python 3.11.5)                                                                 |
|     Platform: Windows-10-10.0.19045-SP0                                                            |
|     Run Mode: Script will exit after completion.                                                   |
|====================================================================================================|
|                                            Starting Run                                            |
|====================================================================================================|
| Locating config...                                                                                 |
| Using Z:\qbit_manage\config\config.yml as config                                                   |
| Commands found in config.yml, ignoring env variables and using config commands instead.            |
| Connecting to Qbittorrent...                                                                       |
| Qbt Connection Successful                                                                          |
|======================================= Getting Torrent List =======================================|
|======================================== Checking Settings =========================================|
|====================================================================================================|
|                                   Gathering Torrent Information                                    |
|====================================================================================================|
|========================================== Updating Tags ===========================================|
|    Torrent Name: neon-user-20231109-0718.iso                                                       |
|         New Tag: openbittorrent                                                                    |
|         Tracker: ws://tracker.openbittorrent.com:80                                                |
| Updated 1 new tags.                                                                                |
|============================= Updating Share Limits based on priority ==============================|
| Assigning torrents to share limit groups...                                                        |
|====================================================================================================|
|                                            Finished Run                                            |
|                                      Total Torrents Tagged: 1                                      |
|                                         Run Time: 0:00:00                                          |
|====================================================================================================|
@bobokun bobokun merged commit 6235951 into StuffAnThings:develop Dec 4, 2023
2 of 3 checks passed
@Antorell Antorell deleted the adds-checks-for-UDP-and-WS-to-the-tag-logic branch December 6, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants